Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update PHP version in doc #11413

Merged
merged 1 commit into from Apr 15, 2024
Merged

Conversation

Nayte91
Copy link
Contributor

@Nayte91 Nayte91 commented Apr 15, 2024

Small fix because I'm annoyed by seeing 7.1 on the ORM 3 doc :)

derrabus
derrabus previously approved these changes Apr 15, 2024
@@ -27,7 +27,7 @@ What is Doctrine?
-----------------

Doctrine ORM is an `object-relational mapper (ORM) <https://en.wikipedia.org/wiki/Object-relational_mapping>`_
for PHP 7.1+ that provides transparent persistence for PHP objects. It uses the Data Mapper
for PHP 8.1+ that provides transparent persistence for PHP objects. It uses the Data Mapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for PHP 8.1+ that provides transparent persistence for PHP objects. It uses the Data Mapper
for PHP that provides transparent persistence for PHP objects. It uses the Data Mapper

Not sure we need a version number here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed with a amend / force push, is it the regular process?

@derrabus derrabus added this to the 3.1.2 milestone Apr 15, 2024
@greg0ire greg0ire merged commit e0e55dc into doctrine:3.1.x Apr 15, 2024
1 check passed
@greg0ire
Copy link
Member

Thanks @Nayte91 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants