New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for DBAL 3 #11216
Draft
derrabus
wants to merge
1
commit into
doctrine:4.0.x
Choose a base branch
from
derrabus:drop/dbal-3
base: 4.0.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Drop support for DBAL 3 #11216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
drop/dbal-3
branch
3 times, most recently
from
February 7, 2024 14:44
e43754c
to
c376858
Compare
derrabus
force-pushed
the
drop/dbal-3
branch
3 times, most recently
from
February 22, 2024 13:00
5aa8a32
to
ebc7951
Compare
There is code here that could be simplified I think: orm/src/Mapping/ClassMetadataFactory.php Lines 627 to 660 in 3907872
|
derrabus
force-pushed
the
drop/dbal-3
branch
4 times, most recently
from
March 1, 2024 10:15
b5a1140
to
5d9b1c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all compatibility code for DBAL 3. I'm flagging it as a draft for now because I believe that we can backport a few things.