Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix break line in caching.rst #10712

Closed
wants to merge 1 commit into from
Closed

Conversation

jaroslavtyc
Copy link

@jaroslavtyc jaroslavtyc commented May 18, 2023

Remove a trailing space in the middle of a sentence causing new line by <br> in result.

<p>In this section we'll describe how you can fully utilize the API of
the cache drivers to save data to a cache, check if some cached data<br>exists, fetch the cached data and delete the cached data. We'll use the
<code>ArrayCache</code> implementation as our example here.</p>

Remove a trailing space in the middle of a sentence causing new line by <br> in result.

```html
<p>In this section we'll describe how you can fully utilize the API of
the cache drivers to save data to a cache, check if some cached data<br>exists, fetch the cached data and delete the cached data. We'll use the
<code>ArrayCache</code> implementation as our example here.</p>
```
@greg0ire
Copy link
Member

Why are you targeting 2.8.x?

@jaroslavtyc jaroslavtyc changed the base branch from 2.8.x to 2.15.x May 19, 2023 08:04
@jaroslavtyc
Copy link
Author

@greg0ire Got there by Google, did not notice.

Latest https://www.doctrine-project.org/projects/doctrine-orm/en/2.15/reference/caching.html#using-cache-drivers does not have that typo (nor the sentence itself) so we can close this as solved already.

@jaroslavtyc jaroslavtyc deleted the patch-1 branch May 19, 2023 08:17
@jaroslavtyc
Copy link
Author

Note: For example Symfony docs have warning "You are browsing old documentation. Consider switch to latest" https://symfony.com/doc/5.3/service_container/alias_private.html

Would be nice for Doctrine docs too.

@greg0ire
Copy link
Member

@jaroslavtyc well it's already the case, isn't it? There is a header with a warning on old Doctrine docs.

@greg0ire
Copy link
Member

The real question is: why does Google send you to an old version? Is there some search engine optimization we could do?

@jaroslavtyc
Copy link
Author

@greg0ire

here is a header with a warning on old Doctrine docs.

And I checked it before I wrote it. Dunno why I have missed it (twice), sorry. Maybe my brain just filtered it out as there is no "Call to action - click here to get to latest version you fool".

The real question is: why does Google send you to an old version? Is there some search engine optimization we could do?

I have used "doctrine redis cache vs native sql" as a search term. Tried it now in private browser window and still the first result leads to old docs. There will be probably some trick how to tell Google to lower old docs rank in search result.

@greg0ire
Copy link
Member

I'm away from my computer now but can you please research "link rel canonical" and see if we implement it? IIRC it should fix that kind of issue.

@jaroslavtyc
Copy link
Author

Yeah, it is there (old docs) https://www.doctrine-project.org/projects/doctrine-orm/en/2.8/reference/caching.html#using-cache-drivers, canonical link to current version <link rel="canonical" href="[https://www.doctrine-project.org/projects/doctrine-orm/en/2.15/reference/caching.html](view-source:https://www.doctrine-project.org/projects/doctrine-orm/en/2.15/reference/caching.html)" /> and seems valid.

Looks like you did maximum to avoid such situation.

@greg0ire
Copy link
Member

That href value looks weird, actually, doesn't it?

@greg0ire
Copy link
Member

greg0ire commented May 19, 2023

Ah no it's just what happens when copy pasting from firefox's view-source I suppose. I double checked with wget and it is fine. What keywords did you use when searching on Google?

@greg0ire
Copy link
Member

Something must be off because both duckduckgo and google seem to show old versions of the docs when typing for instance: "doctrine using cache drivers"

@greg0ire
Copy link
Member

Ah that text does not appear on the page of version 2.15. I guess you must be facing a similar situation.

@jaroslavtyc
Copy link
Author

@greg0ire

Ah that text does not appear on the page of version 2.15. I guess you must be facing a similar situation.

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants