dutch language #173

noud · 2020-09-06T11:33:24Z

hi,
can we have this?
it is the basic of Dutch language inflector.
thanks,
Noud

noud · 2020-09-06T11:34:57Z

oyg, it has "Review required" that i am not used to ....

noud · 2020-09-06T15:12:02Z

ow and Dutch is very irregular so more additions will follow.

greg0ire · 2020-09-06T15:23:59Z

oyg, it has "Review required" that i am not used to ....

It needs we in the team need to review the PR. I will do so when you manage to make the test suite pass. I just contributed #174 , that will help you figure out what is left to do on your next push or if you close and reopen this PR.

greg0ire · 2020-09-06T15:30:47Z

You can run vendor/bin/phpcbf, it will take care of most issues.

noud · 2020-09-06T15:45:35Z

all checks passed and i have now that phpcbf running local as well.
thanks.

greg0ire

Codecov is right, please add some tests. There are examples in tests/Doctrine/Tests/Inflector/Rules/{English,French}

noud · 2020-09-06T15:51:30Z

ok will do was already scared about tests ....

noud · 2020-09-06T16:38:08Z

okay,

so i partly solved a problem
given i have this during actual use:

$ php artisan api-platform:generate
"Adres"
"Afbeelding"
"Link"
"Locatie"
"Politiebureau"
"PolitiebureausLocatie"
"Translation"
"Twitter"
"Wijkagent"
"WijkagentenLinks"
"WijkagentenLocatie"
"WijkagentenTranslations"

(this is from https://github.com/noud/politie-open-data-api)

see the correct "Adres" there
and the failing one in test.

Noud

tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php

greg0ire · 2020-09-06T17:05:00Z

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php

+     */
+    public static function getPlural() : iterable
+    {
+        // allready in plural


It's spelt "already", and I don't understand what this comment is about…

corrected.
and i also have a non-understanding w/ the comment.

originally it came from github.com/noud/cakephp-dutch/blob/master/Config/inflections.php
also used in github.com/enflow/component-inflector/blob/master/src/Language/Dutch.php

Let's remove it then?

may it be let in, as a remider?

a reminder of what? We have no idea what it means…

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php

greg0ire · 2020-09-06T18:20:15Z

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

git rebase -i origin/master, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
A window will show up with many lines, replace pick with fixup on every line but the first one
Close your editor, git should do its magic, and you should end up with one commit
Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

noud · 2020-09-06T18:23:52Z

oyg, i will squash my commits but not immediate .... and if i manage to do that squashing ....

noud · 2020-09-07T14:53:29Z

i managed to squash.

tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php

noud · 2020-10-28T18:46:46Z

Users don't need to know for how long we supported a language in this lib, do they?

correct

noud · 2020-10-28T18:47:13Z

no tweet

noud · 2020-10-28T18:48:02Z

might w/ merge

tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php

TimoBakx · 2020-12-01T21:18:18Z

tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php

+    public function dataSampleWords(): array
+    {
+        return [
+            ['schip', 'schepen'],


I think we need some extra tests here.

Suggested change

['schip', 'schepen'],

['schip', 'schepen'],

['idee', 'ideeën'],

hi you 2,

did swap my incorrectness and did add note for possible rule.

tests running again now.

Hello! 👋

Please also add:

['meer', 'meren'],

['baas', 'bazen'],

['oog', 'ogen'],

['as', 'assen'],

added but outcommented for now.

noud · 2020-12-01T22:16:15Z

@greg0ire question:

PHP CodeSniffer Config installed_paths set to ../../slevomat/coding-standard,../../doctrine/coding-standard/lib
Error: The operation was canceled.

and

Generating code coverage report in Clover XML format ... done [00:00.009]
Error: Process completed with exit code 1.

???

this previous worked say half an hour back.
is your doing?

TimoBakx · 2020-12-01T22:16:39Z

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php

+
+        yield new Substitution(new Word('idee'), new Word('ideeën'));
+
+        // @todo: above 3 examples maybe could be compacted into a rule


This indeed needs to be a rule instead of specific exceptions for these words, for example wee, zee, twee, drie, theorie etc.

for now i see 2 rules:

wee, zee, twee

drie, theorie
but did not make it into rules yet, given i do not know yet if that does conflict other words.

TimoBakx · 2020-12-01T22:21:15Z

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php

+        // http://nl.wikipedia.org/wiki/Meervoud_(Nederlands)#Klinkerverandering
+        yield new Substitution(new Word('lid'), new Word('leden'));
+
+        yield new Substitution(new Word('smid'), new Word('smeden'));


This and the word above should be a rule. Also includes words like ooglid (and other samples of ~lid)

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php

TimoBakx · 2020-12-01T22:41:30Z

Hello.

One more set to test for: ['kies', 'kiezen'],.

I'll check if there are more things to add tomorrow, if that's okay.

Thank you for your work on this!

noud · 2020-12-01T22:54:20Z

I'll check if there are more things to add tomorrow, if that's okay.

and i maybe have to make 1 or 3 rules extra now tomorrow.

now: tomorrow is today and skips to the day after today, pardon me.

noud · 2020-12-01T23:44:12Z

@greg0ire question, remark:

now we also have this:
PHP Fatal error: Uncaught Error: Class 'Doctrine\Tests\Inflector\Rules\LanguageFunctionalTest' not found in /home/noud/workspaces/laravel-workspace/inflector/tests/Doctrine/Tests/Inflector/Rules/English/EnglishFunctionalTest.php:14

??

greg0ire · 2020-12-02T06:59:55Z

I don't have that error locally on 7f6a1b435cdcd14cf1e24dabfb2951c69e04be2c, nor does the CI…

noud · 2020-12-02T07:26:35Z

I don't have that error locally on 7f6a1b435cdcd14cf1e24dabfb2951c69e04be2c, nor does the CI…

@greg0ire can this be related to:

PHP CodeSniffer Config installed_paths set to ../../slevomat/coding-standard,../../doctrine/coding-standard/lib
Error: The operation was canceled.

and

Generating code coverage report in Clover XML format ... done [00:00.009]
Error: Process completed with exit code 1.

???

this previous worked say half an hour back.
is your doing?

i'll look at 7f6a1b4 as well ....

greg0ire · 2020-12-02T07:28:34Z

Yes maybe, try composer install?

noud · 2020-12-02T07:33:43Z

Yes maybe, try composer install?

the github web checks we are talking about.

i just did rm -r vendor && composer install
nothing changed so nothing to commit.

i will add one bogus char or line now and we see....

okay, runs as expected now failing over some later added words to test.

noud · 2020-12-02T10:13:35Z

@SenseException

I can't tell anything about the language, but under this premise we should still proceed with this PR even if we can't find someone who can review the parts of the dutch language.

Please also check the failing coding style build.

maybe my previous reply got lost, error on me.
this reply: i'd like to keep the comments in as pointers for further work.
is okay?

greg0ire · 2020-12-04T19:31:23Z

i'd like to keep the comments in as pointers for further work. is okay?

Given the large number of comments, it seems that there will be a significant amount of work to finish this, right?

Maybe this sounds a bit lame and half work done?

Not going to lie, it does 😬 Why should people use this in production if it only has a 50/50 chance of doing the job properly? Won't this generate a lot of support?

i did read somewhere someone in the known to doctrine gave up on German his own language

Can you find this again? I think it wouldn't make sense to accept a PR on Dutch if German was rejected in a similar case, would it?

TimoBakx · 2020-12-04T19:39:29Z

There is a lot of work still ahead. I think it would be best to implement more rules before merging this. I would love to help out if you want. I have little knowledge of the syntax for the rules, perhaps we could work on this together and improve it for at least most of the rules and hopefully quite a few exceptions.

As it is right now, with some rules for quite common words missing, I don't think it's a good idea to accept/merge this.

noud · 2020-12-04T20:43:00Z

Not going to lie, it does Why should people use this in production if it only has a 50/50 chance of doing the job properly? Won't this generate a lot of support?

support.
For one i think most dutch projects are done in English.
Second i welcome any issues to pick them up. (mind is as we all know free and spare time work)
And, as i experience myself, i have over 50% good results and for sure in dev environment are already a little happy w/ that.
(furthermore i think if anyone keeps the stanza it should be 90% i guess it will never be done we will near never see just one or two PRs on such somewhat complex languages)

I did the same inflections (a bit more) some years ago fot CakePHP and i did read remarks commercial company
we are inspired by that cake work (them copy pasted in full) so there the least is a commercial web build company that is (somewhat) happy w/ it.

Now if we have a uni level linguistic organization around that is well known to Dutch it would not be a problem.

i did read somewhere someone in the known to doctrine gave up on German his own language

Can you find this again? I think it wouldn't make sense to accept a PR on Dutch if German was rejected in a similar case, would it?

It was not rejected, Did not come so far the person coding gave up.
i think this is what i did read (mind German is even worse then Dutch)
#99
"dereuromark commented on Sep 28, 2018": "I once tried as well, and after 500 lines of exceptions and still no where close to having a reliable package " (my idea is Dutch is a bit simpler)

noud · 2020-12-04T20:58:19Z

There is a lot of work still ahead. I think it would be best to implement more rules before merging this. I would love to help out if you want. I have little knowledge of the syntax for the rules, perhaps we could work on this together and improve it for at least most of the rules and hopefully quite a few exceptions.

As it is right now, with some rules for quite common words missing, I don't think it's a good idea to accept/merge this.

O i welcome this Timo, at first i did think yeah you give tests but do not think rules but you do well seem to have the interest, good and nice. So yes help and working together for sure appreciated and accepted. Furthermore i noticed your name might tell about you having a dutch connection like me as well? (mind it is spare and free time work for me)

We have to find and understand the linguistic rules. Maybe see what linguistic organizations are able to help us, think organizations that do dutch text to speech, it is a bit in there lane of work.Some years ago Symfony had a web inflector, see where that thing went, use it as low level step-in for non coding people, maybe also have some web interface to the rule sets and exceptions, so non coding people can have give there input as well. (just a few thoughts)

noud · 2020-12-04T21:10:36Z

latest comments, yes i think Timo brought some words to the table to test, but and also one maybe 2 extra rules. I hope to formulate them so code them pretty soon. 50% or 70-80% i'll get us a random dutch words list and off this commit feed them the inflector and tell you the score.

…

On 04/12/2020 22:00, Claudio Zizza wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php <#173 (comment)>: > + // ['beleg', 'beleggen'], // @todo: meening: call a meeting + // ['beleg', 'belegjes'], // @todo: meening: the slices food on a sandwich Yes, "half of the work" in the same scope usually wouldn't be enough for a merge, but it seems that the latest comments are about finishing the other parts. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#173 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKFS7OAWSZQ7OIZEXGJSTTSTFEXNANCNFSM4Q4JBMMA>.

alcaeus · 2020-12-09T11:43:38Z

Hello @noud,

apologies if me removing myself from the reviewer list caused confusion. I don't have anything to contribute to the review: the technical side is very well covered by @greg0ire and @SenseException, and without any basic knowledge in the Dutch language I am more than unqualified to review language changes.

That said, I welcome the effort you and @TimoBakx are making to add support for Dutch language inflection. I had previously looked at adding support for German, but quickly gave up as many inflections depend on context which this library does not provide. Your plan to take word lists, throw them at the inflector and work to raise the score seems like a sensible approach. When it comes to context sensitive inflections, it may be worth exploring other avenues of solving this.

To bring an example that previously caused breakage, take the word "weather": there are two pluralisations for this word, "weather" and "weathers", and the appropriate one depends on the context. For example, it's correct to say "we're going out in all kinds of weather" (with "weather" being plural here), but also "we've encountered many different types of weathers on our trip". It's impossible for this library to know the context, so instead of thinking how this library can guess this context we should rather allow the user to specify context and add custom inflection rules for their own contexts. So please, don't try to solve every possible use-case, especially the ones this library currently doesn't support. Instead, aim for providing a good baseline and rely on users to deal with strange edge cases themselves.

noud · 2021-03-23T10:11:16Z

to have better insight the dutch nouns i started
https://github.com/noud/nouns-db
and
https://github.com/noud/nouns-laravel

greg0ire reviewed Sep 6, 2020

View reviewed changes

dutch

3c5aa5a

noud force-pushed the master branch from 6f13fe6 to 3c5aa5a Compare September 7, 2020 14:48

noud changed the title ~~dutch~~ dutch language Sep 7, 2020

greg0ire closed this Oct 27, 2020

greg0ire reopened this Oct 27, 2020

greg0ire closed this Oct 28, 2020

greg0ire reopened this Oct 28, 2020

greg0ire changed the base branch from master to 2.1.x October 28, 2020 15:04

greg0ire force-pushed the master branch 2 times, most recently from a4cf50b to eea1cb9 Compare October 28, 2020 15:23

greg0ire reviewed Oct 28, 2020

View reviewed changes

tests/Doctrine/Tests/Inflector/Rules/Dutch/DutchFunctionalTest.php Show resolved Hide resolved

eick point

4a7b0ee

greg0ire force-pushed the master branch from eea1cb9 to 119dfde Compare October 28, 2020 16:10

greg0ire requested review from alcaeus and SenseException October 28, 2020 16:42

meaning spelling

04d6ecf

TimoBakx suggested changes Dec 1, 2020

View reviewed changes

swapped singular plural correction & possoble rule

3d61fb6

TimoBakx reviewed Dec 1, 2020

View reviewed changes

lib/Doctrine/Inflector/Rules/Dutch/Inflectible.php Show resolved Hide resolved

noud added 3 commits December 1, 2020 23:30

removed duplicat row

6547834

extra asked test words

4a1054b

extra asked test words 2

6d2b403

noud added 2 commits December 1, 2020 23:42

possible extra rule

9a6bc70

extra asked test words 3

7f6a1b4

noud added 2 commits December 2, 2020 08:35

comment text added for github web checks

b8a2e59

word typo and new words outcommented rule need

d610fd8

noud requested a review from SenseException December 2, 2020 08:29

	['schip', 'schepen'],
	['schip', 'schepen'],
	['idee', 'ideeën'],


		yield new Substitution(new Word('idee'), new Word('ideeën'));

		// @todo: above 3 examples maybe could be compacted into a rule

dutch language #173

Are you sure you want to change the base?

dutch language #173

Conversation

noud commented Sep 6, 2020

noud commented Sep 6, 2020

noud commented Sep 6, 2020

greg0ire commented Sep 6, 2020 • edited

greg0ire commented Sep 6, 2020

noud commented Sep 6, 2020

greg0ire left a comment • edited

Choose a reason for hiding this comment

noud commented Sep 6, 2020

noud commented Sep 6, 2020

Choose a reason for hiding this comment

noud Sep 6, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg0ire commented Sep 6, 2020

noud commented Sep 6, 2020 • edited

noud commented Sep 7, 2020

noud commented Oct 28, 2020

noud commented Oct 28, 2020

noud commented Oct 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimoBakx Dec 1, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noud commented Dec 1, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimoBakx commented Dec 1, 2020

noud commented Dec 1, 2020 • edited

noud commented Dec 1, 2020

greg0ire commented Dec 2, 2020

noud commented Dec 2, 2020

greg0ire commented Dec 2, 2020

noud commented Dec 2, 2020 • edited

noud commented Dec 2, 2020

greg0ire commented Dec 4, 2020

TimoBakx commented Dec 4, 2020 • edited

noud commented Dec 4, 2020 • edited

noud commented Dec 4, 2020

noud commented Dec 4, 2020 via email

alcaeus commented Dec 9, 2020

noud commented Mar 23, 2021 • edited

greg0ire commented Sep 6, 2020 •

edited

greg0ire left a comment •

edited

noud Sep 6, 2020 •

edited

noud commented Sep 6, 2020 •

edited

TimoBakx Dec 1, 2020 •

edited

noud commented Dec 1, 2020 •

edited

noud commented Dec 1, 2020 •

edited

noud commented Dec 2, 2020 •

edited

TimoBakx commented Dec 4, 2020 •

edited

noud commented Dec 4, 2020 •

edited

noud commented Mar 23, 2021 •

edited