Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unwanted BC break from 5.x series not allowing integer input for validators #823

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

driehle
Copy link
Member

@driehle driehle commented Oct 21, 2023

Closes #818

The release of the 6.x series introduced an unwanted behaviour not allowing integer input to the form validators. This needs to be changed, as integers (e.g. IDs) should be an acceptable input.

@driehle driehle changed the base branch from 6.1.x to 6.0.x October 21, 2023 14:49
@driehle driehle added this to the 6.0.5 milestone Oct 21, 2023
@driehle
Copy link
Member Author

driehle commented Oct 21, 2023

We don't need to care about the Psalm error MissingTemplateParam, this is done in #822.

@driehle driehle requested a review from a team October 21, 2023 14:54
@driehle driehle merged commit 53d3719 into doctrine:6.0.x Oct 25, 2023
9 of 10 checks passed
@driehle driehle deleted the fix/validator-int-input branch October 25, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow cleanSearchValue method to accept an integer
2 participants