Added service for loading data fixtures #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanlaak
approved these changes
May 21, 2019
greg0ire
reviewed
May 21, 2019
# Conflicts: # Command/LoadDataFixturesDoctrineCommand.php
greg0ire
reviewed
May 22, 2019
added 2 commits
May 22, 2019 08:24
|
Shouldn't there be some docs? |
greg0ire
reviewed
May 23, 2019
| } | ||
|
|
||
| $ui->error($message . '.'); | ||
| $doctrineFixtureService = new DoctrineFixtureService($this->fixturesLoader, $em); |
There was a problem hiding this comment.
Should be injected through the constructor, this is a DIP violation.
greg0ire
reviewed
May 23, 2019
| $executor->execute($fixtures, $this->isAppend()); | ||
| } | ||
|
|
||
| public function getPurgeMode() : int |
There was a problem hiding this comment.
This method is only used internally.
greg0ire
reviewed
May 23, 2019
| return $this; | ||
| } | ||
|
|
||
| public function isAppend() : bool |
There was a problem hiding this comment.
This method is only used internally
|
I don't think this PR makes sense at this point and how it was done. The main point is to have the purger and executor injectable, not to extract the logic into a dummy service. As I've explained in #88 (comment), this is currently not possible due to how the underlying library works, but I'm hoping to fix that. In the meantime, I'm closing this PR. Thanks for giving it a shot, @mvmaasakkers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.