allow overriding of services in LoadDataFixturesDoctrineCommand (branch master) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fprochazka
changed the title
| @@ -139,4 +141,32 @@ private function askConfirmation(InputInterface $input, OutputInterface $output, | |||
|
|
|||
| return $questionHelper->ask($input, $output, $question); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
It looks like coding standard is miss matched.
fprochazka
force-pushed
the
services-in-command-can-be-overriden-master
branch
from
17dedf9
to
5c3fa81
Compare
|
I'm closing this PR: for one, we don't want to make the purgers and executors injectable this way. As I've explained in #88 (comment), this needs changes in the underlying library, after which we'll be able to create services for purgers and executors which people can then override based on interfaces. In the meantime, I'm closing this PR. Thanks @fprochazka, and sorry for the very, very, very late feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to override something in executor, but that cannot be done without copy&pasting huge chunks of code in the command. This simple refactoring solves it.