Add NOLINT for String::copy #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #841 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 2 2
Lines 2168 2168
=======================================
Hits 1997 1997
Misses 171 171 ☔ View full report in Codecov by Sentry. |
croemheld
force-pushed
the
fix-string-copy-for-clang-tidy
branch
2 times, most recently
from
cce94f8
to
0265c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
NOLINTcomment for theString::copyfunction to instructclang-tidynot to diagnose this function. More specifically, it instructsclang-tidyonly not to report theclang-analyzer-cplusplus.NewDeleteLeakswarning.This fix was made to conclude the issue #484 together with #659.
GitHub Issues
Closes #484