added bzlmod support #797
Open
added bzlmod support #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #797 +/- ##
==========================================
- Coverage 92.11% 92.11% -0.01%
==========================================
Files 2 2
Lines 2169 2168 -1
==========================================
- Hits 1998 1997 -1
Misses 171 171 |
zaucy
commented
Aug 28, 2023
Comment on lines
+47
to
+58
| # update MODULE.bazel file with version | ||
| print("updating the MODULE.bazel file") | ||
| bzlmod_contents = "" | ||
| for line in fileinput.input(["../MODULE.bazel"]): | ||
| if line.startswith(" version = "): | ||
| bzlmod_contents += " version = \"" + version + "\",\n" | ||
| else: | ||
| bzlmod_contents += line | ||
|
|
||
| bzlmod = open("../MODULE.bazel", "w") | ||
| bzlmod.write(bzlmod_contents) | ||
| bzlmod.close() |
There was a problem hiding this comment.
I didn't test this, but it's almost an exact copy of the meson.build above!
|
The codecov report seems to be inaccurate. It's complaining about a file that I haven't touched 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the latest bazel MODULE system (bzlmod) and refactors the older minimal bazel support. Consuming
doctestin a bazel project becomes as simple as adding this to a usersMODULE.bazelfile:Additionally I added GitHub actions to help with bazel integration. I could only get the 1 example to work correctly, but I think that example would be the most common use case when using bazel.
GitHub Issues
prepares for #687, but does not close it until actually submitted to the BCR