Fix SUBCASE infinite loop

[AlexanderHederstaf]

• Insert and check same hash for fullyTraversedSubcases

Description

Change the saved hash to match the hash later checked in the Subcase constructor.
This fixes an infinite loop that I encountered with at least two different nested SUBCASEs inside a loop.

TEST_CASE("Infinite")
{
  for (int idx = 0; idx < 2; ++idx)
  {
      SUBCASE("A")
      {
          SUBCASE("SUB A")
          {
              std::cout << "sub a" << std::endl;
          }
      }
      SUBCASE("B")
      {
          SUBCASE("SUB B")
          {
              std::cout << "sub b" << std::endl;
          }
      }
  }
}

[codecov]

Codecov Report

Merging #725 (f695fb9) into dev (96273fd) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #725      +/-   ##
==========================================
- Coverage   92.19%   92.05%   -0.14%     
==========================================
  Files           2        2              
  Lines        2127     2153      +26     
==========================================
+ Hits         1961     1982      +21     
- Misses        166      171       +5     

Impacted Files	Coverage Δ
doctest/parts/doctest.cpp	91.66% <100.00%> (-0.05%)	⬇️
doctest/parts/doctest_fwd.h	96.55% <0.00%> (-1.15%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[AlexanderHederstaf]

I encountered this issue when bumping from 2.4.6 to 2.4.9. The impacted test did not have all its asserts trigger previously, related to #597. After the change in this PR all assertions are triggered and the test does not get stuck in an infinite loop.

[AlexanderHederstaf]

Might be related to #684.