Update "versions" curl invocation to be more defensive #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the script to differentiate 404 from 503 so that we are less likely to accidentally commit downgrades for temporary failures.
whalelines
approved these changes
Apr 2, 2024
| @@ -23,8 +23,22 @@ else | |||
| fi | |||
| versions=( "${versions[@]%/}" ) | |||
|
|
|||
| scriptPid="$$" # so we can kill the script even from a subshell | |||
| _curl() { | |||
| exec 42>&1 | |||
yosifkit
approved these changes
Apr 2, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Apr 11, 2024
Changes: - docker-library/docker@b1589f6: Update 26 to 26.0.1 - docker-library/docker@1b4d76a: Merge pull request docker-library/docker#488 from infosiftr/defensive-curl - docker-library/docker@8114f46: Update "versions" curl invocation to be more defensive - docker-library/docker@9329f88: Update 26 to compose 2.26.1 - docker-library/docker@9b7730d: Update 26 to compose 2.26.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the script to differentiate 404 from 503 so that we are less likely to accidentally commit downgrades (like 9b7730d) for temporary failures.
Example output if I change the
caseto not match 200 anymore: