Change the danted internal server address binding to IP address #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redjumper
changed the title
Hagb
requested changes
May 20, 2024
Hagb
reviewed
May 20, 2024
| else | ||
|
|
||
| internals="internal: 0.0.0.0 port = 1080" | ||
| fi | ||
| for iface in $(ip -o addr | sed -E 's/^[0-9]+: ([^ ]+) .*/\1/' | sort | uniq | grep -v "lo\|sit\|vir"); do |
There was a problem hiding this comment.
我最近想到一种通过代理访问 lo 的应用，就是进行 web 登录的时候，可以给浏览器设上代理来访问登录页面，这时登录页面访问 localhost 的时候浏览器就可以通过代理来转发给容器里的对应端口，而无须把那个端口从容器开放出来。不知道这里去掉 lo 有没有什么原因？（这只是一个跑题的回复，此处无需在此次 pr 修改）
There was a problem hiding this comment.
唔，从测试看pasta模式下external不需要监听lo
There was a problem hiding this comment.
哦我的意思是，如果能通过代理访问容器的 127.0.0.1:54530 或者 127.0.0.1:54631 这样的端口的话（web 登录时供浏览器上的登录网页调用），就不需要专门把它们用 -p 映射了
There was a problem hiding this comment.
感觉这种情形下external也不需要监听lo
…g to IP address
Hagb
approved these changes
May 21, 2024
|
感谢贡献！新版本已经 push 到 dockerhub。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #339
danted internal server address not use interface name anymore