Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

Add AclBuilder to all ProcessDirectory invocations #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elordahl
Copy link

@elordahl elordahl commented May 11, 2017

Receiving the following exception due to missing $AclBuilder parameter. Was this omission intentional? An alternative would be a null check prior to use of the var.

Generate_IIS : You cannot call a method on a null-valued expression.
At C:\Program Files\WindowsPowerShell\Modules\Image2Docker\1.8.2\Functions\Private\GenerateDockerfile.ps1:34 char:23
+ ... ockerfile = & "Generate_$Artifact" -MountPath $MountPath -ManifestPat ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Generate_IIS], RuntimeException
    + FullyQualifiedErrorId : InvokeMethodOnNull,Generate_IIS
DEBUG:   60+      >>>> $null = $AclBuilder.AppendLine('RUN $path=' + "'C:$targetPath'; ``")

@sixeyed

Signed-off-by: Eric Lordahl <elordahl@secureauth.com>
Copy link

@pdevine pdevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@pdevine
Copy link

pdevine commented Jul 22, 2017

@sixeyed Can you give it a final review?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants