Fix #5997: avoid log errors during install process. #6001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
reviewed
Apr 9, 2024
| { | ||
| Logger.Error("[1] Error executing SQL: " + sql + Environment.NewLine + ex.Message); | ||
| { | ||
| if (!sql.EndsWith("GetDatabaseVersion")) |
There was a problem hiding this comment.
Should we log this as warning or info?
| @@ -60,7 +60,11 @@ public UpgradeStatus Status | |||
| } | |||
| catch (Exception ex) | |||
| { | |||
| Logger.Error(ex); | |||
| if (this.IsInstalled()) | |||
There was a problem hiding this comment.
Can we log this at a warning or info level?
| } | ||
| } | ||
| catch (FileNotFoundException) |
There was a problem hiding this comment.
Do we need this at both levels?
Is this an issue of dependencies being requested that should be optional (or required dependencies that aren't available before the install)? Do we need to adjust things so that these missing dependencies aren't requested in the first place?
|
We discussed this issue in detail, and although we get the intent, the overall impact to the lack of discovery of possible errors that need debugging we feel that it is better to leave this error message as logged, even though it might be an annoyance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5997: avoid log errors during install process.