simplify union evc

[WalterBright]

No description provided.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16502"

[WalterBright]

Looks like valgrind doesn't like this change.

[thewilsonator]

@ibuclaw any idea what the persistent failure on Main / Ubuntu 22.04 x64, GDC is about?

[ibuclaw]

@ibuclaw any idea what the persistent failure on Main / Ubuntu 22.04 x64, GDC is about?

Could be https://gcc.gnu.org/PR92309

[ibuclaw]

@RazvanN7 did you merge when there are failing pipelines?

[RazvanN7]

I was under the impression that the failure is unrelated.

[RazvanN7]

@ibuclaw revert: #16517

[RazvanN7]

Redone in #16518

[WalterBright]

@RazvanN7 what was the actual problem?

[thewilsonator]

possibly #16502 (comment)

[ibuclaw]

possibly #16502 (comment)

That can be checked by replacing the anonymous union with a named union field + alias this.

If found to be the case, then not much can do about it. I didn't have the foresight to backport the fix to the 9 release branch four years ago, and its frozen/closed now.

You can always use version(GNU) or static if (__VERSION__ <= 2076) to put the workaround behind.

[WalterBright]

Ah. Thanks for getting it fixed!