Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new icon #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update new icon #49

wants to merge 1 commit into from

Conversation

Cap32
Copy link

@Cap32 Cap32 commented Apr 12, 2018

No description provided.

@dkundel
Copy link
Owner

dkundel commented Apr 12, 2018

Hey @Cap32! Thanks for contributing this logo. Could you give a bit more context to this PR. What motivated you to create this, why do you feel like we should update the logo, etc.

@Telokis what do you think about this logo change?

@Cap32
Copy link
Author

Cap32 commented Apr 13, 2018

I'm really like this extension, and IMHO the new one is much more beautiful and modern 😃

@Telokis
Copy link
Collaborator

Telokis commented Apr 13, 2018

Hey @Cap32!
Thanks for your contribution!
As @dkundel said before, It's always better to try to provide some context as to why you are making a PR.

About the logo itself, it's pretty but a bit too simple, in my opinion. There is nothing related to files and it's only about "adding". It misses the critical information.

@dkundel
Copy link
Owner

dkundel commented Apr 14, 2018

Yeah I agree with @Telokis. I'm totally fine with a new logo :) I created this one sort of quickly :D But a bit more context in the logo would be great.

Cheers,
Dominik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants