Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bit flags for SystemStatusList widget ids #186

Open
wants to merge 1 commit into
base: dev-sdk-main
Choose a base branch
from

Conversation

leohoo
Copy link

@leohoo leohoo commented Oct 24, 2023

Since SystemStatusSmartListModel uses bitwise-and to manage item exclusion, we should declare uxsdk_excludeItem and SystemStatusListItem as bit flags.

fun isItemExcluded(excludeItems: Int): Boolean {
return excludeItems and this.value == this.value
}

@Padreco-lbr
Copy link

Padreco-lbr commented Nov 9, 2023

Please accept this pull request, I applied it locally and works fine. The current strategy for item exclusion is simply broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants