Preseeded Immunity #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzrghorbani
reviewed
Dec 2, 2023
There was a problem hiding this comment.
I've reviewed the changes, and I appreciate the approach of reading the immunity fraction from a file, which seems like a good way to handle it. However, I'm open to further discussion regarding alternative methods.
The code runs smoothly, but it might be beneficial to delve into the output results to understand how this implementation impacts the outcomes.
I'll be interested to hear @djgroen's insights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the functionality for preseeded immunity.
It works on my end. could you check if it runs on your end too?
Currently, I don't like how the immunity duration is read from the yml file. If you agree, we can create an issue regarding that.