Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #320 Fix transparent object ordering in 3d #323

Merged
merged 8 commits into from
May 18, 2024
Merged

Fix Issue #320 Fix transparent object ordering in 3d #323

merged 8 commits into from
May 18, 2024

Conversation

Katsutoshii
Copy link
Contributor

Solves #320

@Katsutoshii
Copy link
Contributor Author

Tested with cargo run --example ordering --features="bevy/bevy_winit bevy/bevy_pbr bevy/png 3d examples_world_inspector"

@Katsutoshii Katsutoshii changed the title Issue/320 #320 Fix transparent object ordering in 3d May 15, 2024
@Katsutoshii Katsutoshii changed the title #320 Fix transparent object ordering in 3d Fix Issue #320 Fix transparent object ordering in 3d May 15, 2024
djeedai
djeedai reviewed May 16, 2024
View reviewed changes
Copy link
Owner

@djeedai djeedai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just a few minor things.

src/render/batch.rs Outdated Show resolved Hide resolved
src/render/mod.rs Outdated Show resolved Hide resolved
@djeedai
Copy link
Owner

djeedai commented May 18, 2024

I've changed the example a bit to make sure we can see the blue rectangle being rendered on top and partially (but not completely) affecting the particles:

image

@Katsutoshii
Copy link
Contributor Author

Great, thanks!

@djeedai djeedai merged commit 7b8f0dd into djeedai:main May 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeedai djeedai djeedai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Katsutoshii @djeedai