Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 'Last Modified' field #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop 'Last Modified' field #64

wants to merge 1 commit into from

Conversation

adamchainz
Copy link
Sponsor Member

Following discussion in #62, realized this field is out of sync, we can retrieve the information from Git, and several DEP's never had the field.

manfre
manfre reviewed Sep 30, 2019
View reviewed changes
Copy link

@manfre manfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the :Last-Modified: to reflect when the content/substance of the DEP has last changed, instead of the last time anything in the file was changed? If the latter, then we should definitely remove them.

@adamchainz
Copy link
Sponsor Member Author

Even if it's the former, I believe it's out of sync for most of them.

Base automatically changed from master to main February 25, 2021 16:04
@adamchainz
Copy link
Sponsor Member Author

@felixxm thoughts?

@RealOrangeOne
Copy link

Speaking from my experiences on #86, I often forget to update the Last-Modified field. Sure, it's useful as a marker for "when did this content notably change", but you can get the majority of that from commit history.

Big +1 👍 from me on this!

@carltongibson
Copy link
Member

+1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfre manfre manfre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamchainz @RealOrangeOne @carltongibson @manfre