Updated Django versions #318
Conversation
|
Took me some commits, maybe squash the PR if you like it? 😅 |
.github/workflows/ci.yml
Outdated
| @@ -29,10 +29,12 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
| django-version: [22, 32, 40, 41, 42] | |||
| django-version: [42, 50] | |||
There was a problem hiding this comment.
Do we need to drop support for Django 3? I feel like many people might still be using it.
There was a problem hiding this comment.
Good morning! Well, good question. I always go with: I dont support whats not being supported. Especially, since it doesn't mean, it's not working, we just dont guarentee it.
But I'd say, let's agree on a strategy. What would be best in your opinion?
There was a problem hiding this comment.
I like supporting one version behind if it's not too much of a hassle, if it runs in CI it's easier not to break it.
But you do make a good point. I think we could drop Django 3 if it becomes difficult to support it moving forward, e.g. with a future feature or enhancement.
There was a problem hiding this comment.
@pcraciunoiu I re-added Django 3.2
|
@pcraciunoiu Shall we make a release so the stuff is shown on PyPI? What would you suggest as a version bump? A colleague argues that dropping versions is a major change but it seems a little extreme some times... 🤔 |
|
I wasn't planning on making a release since there is no functionality change, no bug fix. Just a requirement change. I kind of agree a major bump would make sense, but we're dropping support only for Django 2.2 which is already way old, so it shouldn't affect many people. I'd be OK with a minor release too. I wonder if there's additional code cleanup that we could do for Django 2.2 specific imports, but probably not much, if at all. |
|
Hi @pcraciunoiu! I could take a while until we do the next feature, right? So maybe a release now might be beneficial? I agree with you on the major version bump. And about the old code: We could add this pre-commit rule from all-famous Adam Johnson: https://github.com/adamchainz/django-upgrade. I use it in all projects and it works great. |
|
Open to the pre-commit rule if you want to add it. I don't know why we would make a release just to deprecate a requirement though, might as well wait until we have actual changes? |
I'll have a look the next days 👍
If it would only be that, I'll be on board but we're also adding support for the new versions. To be honest, I don't care too much about it but it might discourage some potential users if they don't see on PyPI that we have support (and tests) for the latest versions. |
|
Ahh I missed that. OK I'll wait for your next PR and then release |
|
Your wish is my command: #321 😎 |
Hi @pcraciunoiu
just saw that we're a little out-of-date here. What do you think about dropping some deprecated versions?
Best from Cologne
Ronny