add a test for _update_throttling #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraciunoiu
reviewed
Jan 9, 2023
| @@ -38,6 +38,7 @@ django = ">=2.2" | |||
| importlib-metadata = {version = ">=1", python = "<3.8"} | |||
| cryptography = {version = ">=36.0.2", optional = true} | |||
| requests = {version = ">=2.27.1", optional = true} | |||
| freezegun = "^1.2.2" | |||
There was a problem hiding this comment.
I think this should be a dev dependency, it's only used for tests.
| @@ -227,6 +227,7 @@ def _update_throttling(self): | |||
| # Since I'm not sure how Amazon determines at exactly what | |||
| # point to throttle, better be safe than sorry and let in, say, | |||
| # half of the allowed rate. | |||
| recent_send_times.append(now) | |||
There was a problem hiding this comment.
Is the comment on line 211 still valid with this change?
What did you use this for?
|
@AlaaNour94 Did you see the reply from @pcraciunoiu? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append email send time to
recent_send_timesbefore checking the rate limitAdd test case for _update_throttling