Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support of Django 5 #375

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

verdan
Copy link

@verdan verdan commented Feb 14, 2024


name: Support of Django 5.x
about: Updates the models.py to support Django 5.x
title: "[FEAT] Support of Django 5.x"
labels: 'django, django5'
assignees: ''


Is your feature request related to a problem? Please describe.
We want to update the Django Version in our organization to support Django5. and the index_together is the only blocker from this package.

Describe the solution you'd like
Update the indexes for the models

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This PR also incorporated the changes from branch v1.8, which were not in the master branch yet.

@verdan
Copy link
Author

verdan commented Feb 14, 2024

@yangyubo @schinckel if you can please help review this?

@schinckel
Copy link
Contributor

Does this require a new migration?

Signed-off-by: Verdan <verdan@getselectstar.com>
@verdan
Copy link
Author

verdan commented Feb 15, 2024

It does require the migration, updated migration.

Signed-off-by: Verdan <verdan@getselectstar.com>

# Conflicts:
#	notifications/migrations/0009_alter_notification_options_and_more.py
Signed-off-by: Verdan <verdan@getselectstar.com>
@verdan verdan changed the base branch from master to v1.8 February 15, 2024 09:34
@verdan verdan changed the title Update models.py to support Django 5.x [FEAT] Support of Django 5 Feb 15, 2024
@verdan verdan changed the base branch from v1.8 to master February 15, 2024 09:38
@verdan
Copy link
Author

verdan commented Feb 15, 2024

@schinckel I have also incorporated the changes from branch v1.8 into this PR, to merge everything in the master branch. let me know if you think the otherwise.
Not sure if you want me to update the version as well? I THINK this should be 1.9.0 since we are supporting the new version of Django.

@verdan
Copy link
Author

verdan commented Mar 14, 2024

@schinckel @yangyubo any updates on this?

@verdan
Copy link
Author

verdan commented Apr 15, 2024

@schinckel @yangyubo a gentle reminder to please help get this reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants