Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url to the notifications API #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PetrDlouhy
Copy link
Contributor

This MR adds URL of the target, action and actor url to the API endpoint (if the url is defined by get_url_for_notifications(notification, request) or get_absolute_url() method on the object).

We would like to make notifications loaded through the JS code with links to the target objects.

We wanted to add plain get_absolute_url() to the API endpoint, but we realized, that it is not sufficient in case where the link should depend also on the user that is accessing the notification, so we needed to add the request parameter (and we also added the notification object).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants