Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds URL of the target, action and actor url to the API endpoint (if the url is defined by
get_url_for_notifications(notification, request)
orget_absolute_url()
method on the object).We would like to make notifications loaded through the JS code with links to the target objects.
We wanted to add plain
get_absolute_url()
to the API endpoint, but we realized, that it is not sufficient in case where the link should depend also on the user that is accessing the notification, so we needed to add therequest
parameter (and we also added the notification object).