Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mail_debug command to use aiosmtpd #1841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

weslord
Copy link

@weslord weslord commented Oct 18, 2023

Issue #1831

Python 3.12 dropped asyncore and smtpd

This adds a new dependency aiosmtpd from pypi. Should we add some kind of check and instructional message if the library is not found?

smtpd deprecated by Python 3.6, removed in Python 3.12
@jayvdb
Copy link
Contributor

jayvdb commented Feb 5, 2024

I think it would be useful to add additional tests - currently there is only one, which doesnt test that the server is doing smtp stuff.

And in the Command.handle, add something like

try:
import vobject
except ImportError:
print(self.style.ERROR("Please install vobject to use the vcard export format."))
sys.exit(1)
to check that aiosmtpd is installed.

@ulgens
Copy link
Contributor

ulgens commented Feb 21, 2024

@weslord Any luck with the recommended changes? I can create a PR to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants