debug for decorator option #1815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
debug for decorator option in command "show_urls" |
|
In the for loop of the original code, each iteration overrides the variable decorator, so the problem was that only one url with the specified decorator could be found. The issue is reported here: issues/1773 I changed the variable name so that the variable decorator was not affected, which solved the problem. |
|
Maybe I am missing something but I do not see how this changes anything... line 122 might scope bleed the "decorator" variable but it's reassigned anyways on line 140.... Otherwise add a test-case for this so we can demonstrate this fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.