ModelUserFieldPermissionMixin: fix error in checking for the right user of an edited model instance #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of an edited model instance, fix tests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mixin so far test for the right user against the first entry of Model.objects.all(). This entry has, most of the time, nothing to do with the actual entry (to edit/update/delete). Now the mixin tests the actual user against the user of the actual model instance given by pk or slug.
Fix tests accordingly. Until now, the tests for the mixin confirm the produced results (anonymous user) and test not the real expectation (second user can't get data of the first user).