Autoupdate pre-commit hooks & fix linting for runserver_plus.py #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2022
|
Flake8 has some breaking changes and bugs with the 6.0 version. I wouldn't recommend updating it to the latest for now. |
|
As state in the issue, we are already using What problems do you encounter using flake8? I did not need to make any modifications to get the CI to pass. |
ulgens
approved these changes
Dec 12, 2022
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1776 by updating the pre-commit hooks to there latest version. The change in runserver_plus.py:76 is needed to satisfy mypy.