fix(dumpscript): handle formatting of tuples #1746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With tuples it would fail to format it:
```
File "…/django_extensions/management/commands/dumpscript.py", line 360, in get_waiting_list
value = get_attribute_value(self.instance, field, self.context, force=force, skip_autofield=skip_autofield)
File "…/django_extensions/management/commands/dumpscript.py", line 697, in get_attribute_value
item_locator = orm_item_locator(value)
File "…/django_extensions/management/commands/dumpscript.py", line 77, in orm_item_locator
clean_dict[key] = str("%s" % v)
TypeError: not all arguments converted during string formatting
```
|
With regard to #1493 it should maybe use |
aysudeliahmetoglu
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With tuples it would fail to format it: