Using counter0 instead of revcounter0 to check if item is last in ForLoopSimulator #942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
While using the formset utilities I ran into a strange behavior: when you try to use
forloop.last
to apply specific settings like shown in the docs, theforloop.last
variable is never evaluted toTrue
, if there is more than a form in the formset.Digging a bit in the code I found out the
ForLoopSimulator
, and I believe that inForLoopSimulator::iter(...)
,self.last
is wrongly updated.The fix I submitted changes just the variable used to check against
self.len_values-1
fromself.revcounter0
toself.counter0
(although, there are a ton of different ways to check if the current item is the last item 馃槄)