Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Django 4.0 and 4.1. #1368

Merged
merged 1 commit into from Oct 12, 2023
Merged

Drop Django 4.0 and 4.1. #1368

merged 1 commit into from Oct 12, 2023

Conversation

smithdc1
Copy link
Member

As I understand it Django recomends dropping 4.1 upon release of 5.0. That's only a few weeks away now so I'm doing that now.

Maybe that's too early, but it's only really classifers that will change, it will still work as we still have dependencies = ["django>=3.2"].

If it's too early, we can just hold a release back a few weeks, there's not been any funcionality change since 2.0.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #1368 (93fdb0d) into main (4c5cea5) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   89.30%   89.30%           
=======================================
  Files          12       12           
  Lines        1010     1010           
  Branches      192      192           
=======================================
  Hits          902      902           
  Misses         78       78           
  Partials       30       30           
Flag Coverage Δ
unittests 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5cea5...93fdb0d. Read the comment docs.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the harm at this point.

It might be time to drop 3.2 as well... (It's not like the current version stops working...)

@smithdc1
Copy link
Member Author

It might be time to drop 3.2 as well.

Will think about this. 👍

@smithdc1 smithdc1 merged commit e3eb35f into main Oct 12, 2023
6 checks passed
@smithdc1 smithdc1 deleted the drop-old-versions branch October 12, 2023 16:29
@smithdc1 smithdc1 added this to the 2.1 Release milestone Oct 15, 2023
@uri-rodberg
Copy link

If it's too early, we can just hold a release back a few weeks, there's not been any funcionality change since 2.0.

Personally I think it's too early. Django 4.1 and 3.2 are still supported (until December 2023 and April 2024 respectively). Actually I tried to upgrade all my packages with pip, and I was surprised to see that django-crispy-forms has been released but was not upgraded, until I found you dropped support for Django 3.2 and 4.1. Consider releasing a new version of django-crispy-forms supporting Django 3.2 and 4.1, which are still supported for the next 6 months (3.2). It's not common to drop support for a package that is still supported. But I don't mind using django-crispy-forms==2.0, which still supports Django 4.1, until the next time I upgrade Django. I just say it's not common to drop support for a supported package like this.

@carltongibson
Copy link
Collaborator

@uri-rodberg The existing version continues to work for you as-is. If you're not already on Django 4.2, updating Django is going to be of significantly more benefit than being on the latest crispy-forms.

This release is in preparation for Django 5.0, in pre-release now. When that's final 4.1 will be EOL, and the Django docs recommend dropping all support for Django<4.2 at that point. (That includes the not EOL Django 3.2.)

It's time to update.

Rather than sit on this release until 5.0 is final, just for the last moments of Django 4.1, it's better to release it now. Those on 4.1 just don't update. Everyone else gets the new version.

@uri-rodberg
Copy link

@carltongibson OK, I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants