Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed render_field for formset (#1169) #1173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wail-asad
Copy link

No description provided.

@wail-asad wail-asad changed the title Fixed render_field for formset Fixed render_field for formset (#1169 issue) Jun 12, 2021
@wail-asad wail-asad changed the title Fixed render_field for formset (#1169 issue) Fixed render_field for formset (#1169) Jun 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1173 (c453797) into main (7ce02ff) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   97.20%   97.10%   -0.11%     
==========================================
  Files          23       23              
  Lines        2867     2870       +3     
  Branches      243      244       +1     
==========================================
  Hits         2787     2787              
- Misses         39       41       +2     
- Partials       41       42       +1     
Flag Coverage Δ
unittests 97.10% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crispy_forms/utils.py 90.00% <0.00%> (-3.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce02ff...c453797. Read the comment docs.

@wail-asad
Copy link
Author

@smithdc1 the coverage decrease is due to the test, if I make the test, Is will be executed by codecov before the merge?
This doesn't encourage me to push the layout design for tabular formset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants