Added site field in models n site filter in admin #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…hub.com/vipulnarang95/djangocms-snippet into feature/add-site-field-in-snippet-model
|
@fsbraun Can you please review this? |
marksweb
approved these changes
May 7, 2024
fsbraun
requested changes
May 7, 2024
There was a problem hiding this comment.
@vipulnarang95 Can I suggest a few things to make this fully integrated:
- Only offer snippets in the create and edit plugin forms that belong to either no site (implying no site restriction) or the current site
- Only render snippets if they belong to the current site (or have no site which means available on all sites). The reason to do this is that the site field of a snippet can change over time. I would assume that a site only renders snippets that are "legal" on the site
- Can you add tests for the snippet selection, rendering and upon changing site?
I would like to port forward / (backward?) the changes to the main branch later.
Co-authored-by: Mark Walker <theshow@gmail.com>
|
@fsbraun Can you also approve the workflow run please? |
fsbraun
approved these changes
May 14, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added site field in Snippet Model
Added site filter in Snippet admin