Minor improvement in RabbitMQ executor #1500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
ee97ccf
to
8ce2e10
Compare
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
8ce2e10
to
f50de71
Compare
ivan-kripakov-m10
force-pushed
the
rabbit_mq_plugin_updates
branch
from
5c8a9c0
to
38efd8a
Compare
ivan-kripakov-m10
changed the title
vcastellm
reviewed
Mar 31, 2024
| } | ||
|
|
||
| func createQueueIfNecessary(cfg map[string]string, queue string, ch *amqp.Channel) error { | ||
| if val, ok := cfg["queue.create"]; !ok || (ok && val == "false") { |
There was a problem hiding this comment.
Should this query rabbit in order to check if the queue already exists?
There was a problem hiding this comment.
I think we don't need to check if the queue exists here. If the user chooses not to create the queue via the plugin, we expect him to create it manually.
If the user doesn't declare the queue, message publishing will fail with error in logs or a failed execution in UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide possibility to decide whether to create queues when using RabbitMQ executor and possibility to choose queue's configuration (
durable,auto_delete,exclusive) if user decides to create the queue via plugin.Also allows users to customize message publishing using
messageId,contentTypeanddelivery_modeoptions.