Move nginx cache into /srv/pbench #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1316 Our deployed containerized server maps `/var/lib` (the default NGINX cache location) to `/home`, which has only 26Gb free. Instead, map NGINX cache to our large Pbench volume at `/srv/pbench/nginx` in order to be able to transfer larger datasets.
dbutenhof
added
Server
API
webbnh
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
The changes look OK to me.
The one bit of feedback I would offer is that the PR description suggests that we're changing the mapping of volumes into the container, when what we're actually doing is changing the Nginx configuration to use a directory different from the default.
That's what I said. But I get you're stuck on the word "map". I guess I can squash it different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1316
Our deployed containerized server maps
/var/lib(the default NGINX cache location) to/home, which has only 26Gb free. Instead, configure NGINX to use to our large Pbench volume at/srv/pbench/nginxin order to be able to transfer larger datasets.