Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration date update #3597

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

MVarshini
Copy link
Contributor

PBECNH-1311

Expiration date update

@MVarshini MVarshini added the Dashboard Of and relating to the Dashboard GUI label Jan 10, 2024
@MVarshini MVarshini self-assigned this Jan 10, 2024
@MVarshini MVarshini added this to In progress in v0.72 via automation Jan 10, 2024
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed from this branch, and it doesn't seem to fix the problem for me. I still lose focus on the first click...

Screencast.from.2024-01-10.09-14-01.webm

@dbutenhof
Copy link
Member

Since you'd done a rebase on this branch a few days ago, I'd been meaning to get around to pulling the branch to check whether it was working now; and I'm still seeing the same behavior. The focus doesn't stick, and the calendar picker doesn't actually change the date.

Could this be related to Webb's comment about the dispatch behavior? Or is something else going wrong? And, is this only me (and perhaps Chrome)? Is it working for you?

(FYI, I did a full runlocal and connected to https://localhost:8443/dashboard ... I suppose that if you're using dev mode, there might be a difference?)

@MVarshini
Copy link
Contributor Author

As there were problems with PatternFly Datepicker in production replaced it with react-datepicker. This would resolve the problem that we encounter in editing the expiration date.

Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "from" calendar popup and text entry are working, so that's great. However the "to" calendar and text entry remain grayed out and inactive, along with the Update button.
image

Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Dave's concern has been addressed, I'm good with this merging, with the expectation that the fix to the other problem will come in its own PR.

v0.72 automation moved this from In progress to Reviewer approved Feb 27, 2024
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Varshini wants to fix the to/update problem separately, so let's go.

@dbutenhof dbutenhof merged commit f8654f3 into distributed-system-analysis:main Feb 28, 2024
4 checks passed
v0.72 automation moved this from Reviewer approved to Done Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Of and relating to the Dashboard GUI
Projects
v0.72
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants