Add possibility for setting prefix on custom metrics, solves #49 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would also like to have this feature. |
|
Yeah it is a nice change @thomasbalsloev sorry I left it so long, can you also add a note to README here that teaches about usage? |
|
Hi Sam. I added a note to the README about the custom prefix. BR, Thomas. |
SamSaffron
reviewed
Aug 27, 2021
| PrometheusExporter::Metric::Base.default_labels = { "hostname" => "app-server-01" } | ||
|
|
||
| # Counter instance with custom prefix for this metric | ||
| counter = PrometheusExporter::Metric::Counter.new("web_requests", "number of web requests", "my_custom_prefix") |
There was a problem hiding this comment.
Oh, I think there is typo here?
PrometheusExporter::Metric::Counter.new("web_requests", "number of web requests", prefix: "my_custom_prefix")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SamSaffron
Added possibility to set prefix on custom metrics.
Let me hear what you think of the code enclosed.
BR, Thomas.