Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Extend embeddable hosts with Individual tags and author assignments #26868

Merged
merged 18 commits into from May 16, 2024

Conversation

jmperez127
Copy link
Member

@jmperez127 jmperez127 commented May 3, 2024

Beyond the general settings for embeddings, this PR adds the ability to set tags and authors on individual EmbeddableHost records. This allows admins more precise control over content embedded from external hosts into Discourse topics.

CleanShot 2024-05-10 at 10 44 57

@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label May 7, 2024
@jmperez127 jmperez127 changed the title FEATURE: extend embeddable hosts with options to specify tags and users FEATURE: Extend embeddable hosts with tag and author assignment per record May 8, 2024
@jmperez127 jmperez127 changed the title FEATURE: Extend embeddable hosts with tag and author assignment per record FEATURE: Extend embeddable hosts with Individual tags and author assignments May 8, 2024
@jmperez127 jmperez127 marked this pull request as ready for review May 10, 2024 14:50
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/should-discourse-make-an-effort-to-become-a-viable-comment-platform/274455/41

Copy link
Contributor

@megothss megothss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also adding some system tests for the Admin UI

db/migrate/20240430052017_create_embeddable_host_tags.rb Outdated Show resolved Hide resolved
spec/models/embeddable_host_tag_spec.rb Outdated Show resolved Hide resolved
app/controllers/admin/embeddable_hosts_controller.rb Outdated Show resolved Hide resolved
@jmperez127 jmperez127 requested a review from megothss May 14, 2024 20:51
Copy link
Contributor

@megothss megothss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jmperez127 jmperez127 merged commit 63b7a36 into main May 16, 2024
16 checks passed
@jmperez127 jmperez127 deleted the feature-add-tags-and-users-to-embeddable-hosts branch May 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n PRs which update English locale files or i18n related code
3 participants