DEV: allows for multiple menus/tooltips #26823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
force-pushed
the
member-xp/multiple-menus-tooltips
branch
2 times, most recently
from
43ea1f3
to
41b4df0
Compare
menus and tooltips are now appended to their own portals. The service are the only responsible for managing the instances, prior to this commit, services could manage one instance, but the DMenu and DTooltip components could also take over which could cause unexpected states. This change also allows nested menus/tooltips. Other notable changes: few months ago core copied the CloseOnClickOutside modifier of float-kit without removing the float-kit one, this commit now only use the core one. the close function is now trully async the close function accepts an instance or an identifier as parameter
jjaffeux
force-pushed
the
member-xp/multiple-menus-tooltips
branch
from
41b4df0
to
702c053
Compare
CvX
approved these changes
May 7, 2024
app/assets/javascripts/float-kit/addon/components/d-tooltip.gjs
Outdated
Show resolved
Hide resolved
| @tracked tooltipInstance = null; | ||
| registerTrigger = modifier((element) => { | ||
| if (!this.tooltipInstance?.trigger) { | ||
| next(() => { |
There was a problem hiding this comment.
What breaks without this next()? 😄
There was a problem hiding this comment.
More seriously I had exceptions in tests I think
There was a problem hiding this comment.
@CvX here is the exact error without the next:
global failure: Error: Assertion Failed: You attempted to update _trigger on DTooltipInstance, but it had already been used previously in the same computation. Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.
There was a problem hiding this comment.
I will merge with the next for now, but open to a better solution if you know one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menus and tooltips are now appended to their own portals. The service are the only responsible for managing the instances, prior to this commit, services could manage one instance, but the DMenu and DTooltip components could also take over which could cause unexpected states.
This change also allows nested menus/tooltips.
Other notable changes:
CloseOnClickOutsidemodifier of float-kit without removing the float-kit one, this commit now only use the core one.