UX: expand threads list tap area on mobile #26818
Merged
+73
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbattersby
changed the title
dbattersby
force-pushed
the
expand-thread-tap-area-mobile
branch
from
b8578e8
to
093402a
Compare
jjaffeux
reviewed
May 2, 2024
plugins/chat/assets/javascripts/discourse/components/thread-title/index.gjs
Outdated
Show resolved
Hide resolved
|
@chapoi can you look at this please? |
jjaffeux
reviewed
May 2, 2024
|
Looks like the layout has changed now (no longer stretching full width), will see if I can fix it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a wrapper link around the thread list details on mobile to make the click area larger.
We also update child div elements to span to ensure valid html, since the link is an inline element and divs are block level.