DEV: Improve built-in browser performance marks/measurements #26758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `discourse-booted` to 'discourse-init' (because 'booted' makes it sound like boot was finished. When in fact, it was just starting) - Introduce `discourse-paint`, which is fired after the Ember application has been painted to the screen by the browser. This happens slightly after DOMContentLoaded - Add a `performance.measure` call to link those two marks, so they're easily visible in performance traces Also removes an ember boot-order workaround which is no longer required.
CvX
approved these changes
Apr 25, 2024
tgxworld
reviewed
May 2, 2024
| let element = document.querySelector( | ||
| `meta[name="discourse/config/environment"]` | ||
| ); | ||
| const config = JSON.parse( | ||
| decodeURIComponent(element.getAttribute("content")) | ||
| ); | ||
| const event = new CustomEvent("discourse-booted", { detail: config }); | ||
| const event = new CustomEvent("discourse-init", { detail: config }); |
There was a problem hiding this comment.
I'm not entirely sure where this is used but do we need to maintain backwards compatibility here in case there are plugins or themes relying on this event?
There was a problem hiding this comment.
We'll need to update discourse-client-performance, yeah. I'm not aware of anything else relying on it.
davidtaylorhq
added a commit
to discourse/discourse-client-performance
that referenced
this pull request
May 2, 2024
- discourse-init is a direct replacement for the old discourse-booted metric. - discourse-paint is a new metric which tells us when the Discourse UI is actually rendered to the screen Ref discourse/discourse#26758
davidtaylorhq
added a commit
to discourse/discourse-client-performance
that referenced
this pull request
May 2, 2024
- discourse-init is a direct replacement for the old discourse-booted metric. - discourse-paint is a new metric which tells us when the Discourse UI is actually rendered to the screen Ref discourse/discourse#26758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
discourse-bootedto 'discourse-init' (because 'booted' makes it sound like boot was finished. When in fact, it was just starting)Introduce
discourse-paint, which is fired after the Ember application has been painted to the screen by the browser. This happens slightly after DOMContentLoadedAdd a
performance.measurecall to link those two marks, so they're easily visible in performance tracesAlso removes an ember boot-order workaround which is no longer required.