FEATURE: noAutoClass option for DButton component
#26701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often when styling
.btnin themes, some styles get applied in undesirable places:This PR gives the option of passing
noAutoClasstoDButtonto exclude various automatically appended class names.This is useful for situations where you'd still like to use
DButtonbut don't want buttons to have default button styles applied.I've applied this to two common scenarios — the "more" and "customize this section" buttons in the sidebar. These are technically buttons, but should not be styled along with other buttons when a theme uses the
.btnclass.This also simplifies our default CSS, because we no longer have to override our own button styles.