FEATURE: change status on unsolve & fix assign changes #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a topic is unsolved, it should have an option, defined in the settings, to change its status to that state. Fix assign changes when a topic was solved, previously it was changing the assignee.
Update tests to verify that the change status on solve feature is working as expected. Change the implementation to loop throught the topic assignments and update the status.
markvanlan
reviewed
May 8, 2024
plugin.rb
Outdated
| post.acting_user, | ||
| status: SiteSetting.assignment_status_on_solve, | ||
| ) | ||
| assignements = Assignment.where(topic: post.topic) |
There was a problem hiding this comment.
assignements -> assignments ;)
There was a problem hiding this comment.
You can do
assignments = Assignment.includes(:target).where(topic: post.topic)which will preload the target to avoid an N+1 query thennnnn we avoid the whole switch statement and do
Assigner.new(assignment.target, assigned_user).assign(
assigned_user,
status: SiteSetting.assignment_status_on_solve,
)
markvanlan
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a topic is unsolved, it should have an option, defined in the settings, to change its status to that state.
Fix assign changes when a topic was solved; previously, it changed the assignee.