Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Change accept_all_solutions_trust_level to group setting #276

Merged
merged 3 commits into from Jan 23, 2024

Conversation

martin-brennan
Copy link
Contributor

New setting is accept_all_solutions_allowed_groups,
c.f. https://meta.discourse.org/t/changes-coming-to-settings-for-giving-access-to-features-from-trust-levels-to-groups/283408

Also move guardian extensions and accepted_answer_cache into other files,
this refactor makes for easier testing and makes things
more organised, the guardian extensions had no testing
whatsoever and I need some to make the TL -> group change.

This refactor makes for easier testing and makes things
more organised, the guardian extensions had no testing
whatsoever and I need some to make the TL -> group change.
Copy link
Contributor

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The commit history really made this piece of cake. 🍰

Do we need to update any translations though? 🤔

@martin-brennan
Copy link
Contributor Author

Sorry I missed the translations, updated now :)

@martin-brennan martin-brennan merged commit 444dac8 into main Jan 23, 2024
4 checks passed
@martin-brennan martin-brennan deleted the dev/move-tl-setting-to-group-and-refactor branch January 23, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants