Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: make JSON_LD schema consistent with our microdata in core #269

Merged
merged 2 commits into from Nov 22, 2023
Merged

FIX: make JSON_LD schema consistent with our microdata in core #269

merged 2 commits into from Nov 22, 2023

Conversation

arpitjalan
Copy link
Member

CvX
CvX reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a prettier pass and a specs update?

@arpitjalan
Copy link
Member Author

@CvX Fixed linting issues and updated specs.

@arpitjalan arpitjalan merged commit ad1b7c9 into main Nov 22, 2023
4 checks passed
@arpitjalan arpitjalan deleted the jsonld-improvements branch November 22, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@arpitjalan @CvX