FIX: Correct getOwner import #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it's currently implemented, the fallback is essential here. `this` in a static method is `undefined`, and therefore cannot have an owner. Unfortunately this plugin outlet does not seem to be tested in the plugin's own test suite. Core's test suite picked up this issue. Followup to 3a0b46d
davidtaylorhq
force-pushed
the
fix-owner
branch
from
19707e0
to
d5da170
Compare
lis2
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's currently implemented, the fallback is essential here.
thisin a static method isundefined, and therefore cannot have an owner.Unfortunately this plugin outlet does not seem to be tested in the plugin's own test suite. Core's test suite picked up this issue.
Followup to 3a0b46d