s/class_name/name/g #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanrizzi
approved these changes
Apr 26, 2024
Using `AisSortBy` doesn't re-render the `@template` when `searchType` changes more than once. This commit takes another approach by using a `ComboBox` to switch between `searchType` and show a completely new search instance when the search type is changed.
conditionally show each refinement list
- Support for Discourse category search priority - Group / TL refinements for user search - Chat search highlight - Category ID field for posts / topics - Only index public groups for users
Also, `.search()` being called is not necessary here as setQuery is sufficient across sort modes as the search auto updates anyways
- Replaces deprecated `searchFunction` with `onStateChange` - Implements service to have easy access to `searchInstance` and `helper` - Debounces hyde/hybrid/semantic search modes to 60s to prevent issues - Re-introduces hyde and semantic into search mode picker - `setUiState` instead of `search()` ensures infinite hits "Load More" button does not break
This fixes an issue where you get an error if you do a topic search, then switch to chat messages and click the advanced filters button `this.args.uiState` is null. This also removes the `currentRefinements` data attribute. It's not currently being used in CSS and conditionally showing the refinements would be better done in the JS instead of CSS anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.