Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: correct module-level setup #3215

Merged
merged 1 commit into from May 14, 2024
Merged

tests: correct module-level setup #3215

merged 1 commit into from May 14, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented May 10, 2024

@mr-c
Copy link
Contributor Author

mr-c commented May 10, 2024

Build failures appear to be false positives due to other tests issuing warnings which are being treated as errors.

skoudoro
skoudoro approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mr-c,

Thank you for looking into this and apologize for taking the time to check this.

Looks good to me so merging despite the unrelated warnings as errors

@skoudoro skoudoro merged commit 2a0995b into dipy:master May 14, 2024
7 of 29 checks passed
@mr-c mr-c deleted the pytest8 branch May 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

Assignees
No one assigned
Labels
type:Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.9.0 system test failures
2 participants
@mr-c @skoudoro