RF - remove buffer argument in pmf_gen.get_pmf_value(.) #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gabknight, Can you rebase this PR? Thank you |
gabknight
force-pushed
the
RF_get_pmf_value_c
branch
from
07371bb
to
0a0111b
Compare
|
Hi @skoudoro, rebase done. Let's see if all tests pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3214 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 153 153
Lines 21340 21340
Branches 3445 3445
=======================================
Hits 17873 17873
Misses 2611 2611
Partials 856 856 |
skoudoro
approved these changes
May 15, 2024
|
thanks @gabknight ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed an unnecessary argument
pmf_bufferadded in PR #3211This is a speed and memory improvement. Because
get_pmf_value()returns a double, the computation can be done for a single point on the sphere, rather than the whole sphere, thus removing the need for the buffer.