[WIP][CI] warning as error at compilation level #3203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3203 +/- ##
==========================================
+ Coverage 83.75% 83.76% +0.01%
==========================================
Files 153 153
Lines 21340 21340
Branches 3445 3445
==========================================
+ Hits 17873 17876 +3
+ Misses 2611 2608 -3
Partials 856 856 |
skoudoro
force-pushed
the
werror-compilation
branch
2 times, most recently
from
6b1965b
to
60852c3
Compare
skoudoro
force-pushed
the
werror-compilation
branch
from
60852c3
to
609b443
Compare
|
This task will be less easy than expected. We do not control the code generated by Cython. Currently, I often encounter C4101 warnings (unreferenced local variable). Not sure why those variables are created since they are not needed and present in the Still investigating..... |
|
closing, since there is tons of work before a viable PR. Iw ill work back on this topic during the summer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to make sure we have no warnings when we compile our
Cextension.This PR is in work in progress. It should be ok for macOS and Linux but I expect it to fail for Windows. So, I need to connect to a windows machine to handle those issues.
fix #2588